Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(departure-releases): fix colours in the release status view and add documentation #293

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions docs/UserGuide/Features/DepartureReleases.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,18 @@ There are two options for viewing the status of releases that you have requested
and Countdown TAG items described below, or you can use the `Open Departure Release Status View` TAG function to popup
a temporary display for a given aircrafts releases.

The `Departure Release Status View` displays the callsigns of controllers that have been targeted for release, the time
until the release becomes active, if the release has been approved and has a conditional released at time, and the time until the release
approval expires if the release is approved and has an expiry.

The controller callsign indicates the status of the release:

- Green = Approved
- Red = Rejected
- Orange = Request has expired and another one should be made
- Blue = Acknowledged
- White = Pending

## How Do I Respond To A Release Request?

If you are the target of a release request, you can use the `Departure Release Decision List` to make decisions on individual
Expand Down
1 change: 1 addition & 0 deletions msvc/UKControllerPlugin/UKControllerPlugin.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@
<ClInclude Include="..\..\src\releases\ApproveDepartureReleaseDialog.h" />
<ClInclude Include="..\..\src\releases\CompareDepartureReleases.h" />
<ClInclude Include="..\..\src\releases\CompareEnrouteReleaseTypes.h" />
<ClInclude Include="..\..\src\releases\DepartureReleaseColours.h" />
<ClInclude Include="..\..\src\releases\DepartureReleaseCountdownColours.h" />
<ClInclude Include="..\..\src\releases\DepartureReleaseDecisionList.h" />
<ClInclude Include="..\..\src\releases\DepartureReleaseEventHandler.h" />
Expand Down
3 changes: 3 additions & 0 deletions msvc/UKControllerPlugin/UKControllerPlugin.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,9 @@
<ClInclude Include="..\..\src\releases\ToggleDepartureReleaseDecisionList.h">
<Filter>src\releases</Filter>
</ClInclude>
<ClInclude Include="..\..\src\releases\DepartureReleaseColours.h">
<Filter>src\releases</Filter>
</ClInclude>
</ItemGroup>
<ItemGroup>
<ResourceCompile Include="..\..\resource\UKControllerPlugin.rc">
Expand Down
4 changes: 2 additions & 2 deletions src/releases/DepartureReleaseRequestView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,11 @@ namespace UKControllerPlugin {
}

if (request->RequestExpired()) {
return statusIndicatorReleaseAcknowledged;
return statusIndicatorReleaseExpired;
}

if (request->Acknowledged()) {
return statusIndicatorReleased;
return statusIndicatorReleaseAcknowledged;
}

return statusIndicatorReleasePending;
Expand Down