Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prenote messages push events #329

Conversation

AndyTWF
Copy link
Contributor

@AndyTWF AndyTWF commented Aug 25, 2021

Push events for prenote messages:

  • New message
  • Acknowledge message
  • Delete message

Also includes an internal time-out to replace stale messages.

@AndyTWF AndyTWF marked this pull request as ready for review August 30, 2021 16:11
@AndyTWF AndyTWF requested a review from AxonC August 30, 2021 16:11
@AndyTWF AndyTWF changed the base branch from main to feature/prenote-messages September 4, 2021 11:30
@AndyTWF AndyTWF merged commit 0c54df3 into VATSIM-UK:feature/prenote-messages Sep 4, 2021
AndyTWF added a commit that referenced this pull request Sep 17, 2021
* Prenote message storage (#327)

* Rename Class

* Start New Class

* Tidy and Test

* More Files

* Styling

* Allow Storage Of Prenote Messages

* Allow Collection To Be Locked

* Clang Tidy

* Fix Typo

* Const It

* Prenote outbound api calls (#328)

* Request Builder Functions

* Style

* Tidy Up The Api Helper

* Add To ApiHelper

* Formatting

* Fix missing constructor for ApiInterface

* Fix Method

* Prenote messages push events (#329)

* Rename Class

* Start New Class

* Tidy and Test

* More Files

* Styling

* Allow Storage Of Prenote Messages

* Allow Collection To Be Locked

* Clang Tidy

* Fix Typo

* Const It

* Process incoming prenote messages

* Format

* Format

* Acknowledge Messages

* More Format

* Delete Prenote Messages

* Time out old messages

* Format

* Check controllers exist when creating new prenotes

* Prenote messages tag items (#332)

* Request Builder Functions

* Style

* Tidy Up The Api Helper

* Add To ApiHelper

* Formatting

* Fix missing constructor for ApiInterface

* Fix Method

* Status indicator tag item

* Start cancellation menu

* Cancelling Prenote Menu

* Allow controller positions to have prenote permissions

* Only allow deletion of prenotes by responsible controllers

* Sending prenote messages

* Formatting

* Add sound for new prenote received (#336)

* Prenote messages visuals (#335)

* Message status view

* Adjust width

* Add acknowledge prenote message tag function

* Fix cmake

* Start pending prenote list

* Fix test

* Pending prenote list

* Tweaks

* Prenote docs (#337)
VATSIMUK pushed a commit that referenced this pull request Sep 18, 2021
# [3.6.0](3.5.0...3.6.0) (2021-09-18)

### Features

* **prenotes:** Electronic prenote messages ([#330](#330)) ([8ed705d](8ed705d)), closes [#327](#327) [#328](#328) [#329](#329) [#332](#332) [#336](#336) [#335](#335) [#337](#337)
AndyTWF added a commit that referenced this pull request Sep 20, 2021
* Prenote message storage (#327)

* Rename Class

* Start New Class

* Tidy and Test

* More Files

* Styling

* Allow Storage Of Prenote Messages

* Allow Collection To Be Locked

* Clang Tidy

* Fix Typo

* Const It

* Prenote outbound api calls (#328)

* Request Builder Functions

* Style

* Tidy Up The Api Helper

* Add To ApiHelper

* Formatting

* Fix missing constructor for ApiInterface

* Fix Method

* Prenote messages push events (#329)

* Rename Class

* Start New Class

* Tidy and Test

* More Files

* Styling

* Allow Storage Of Prenote Messages

* Allow Collection To Be Locked

* Clang Tidy

* Fix Typo

* Const It

* Process incoming prenote messages

* Format

* Format

* Acknowledge Messages

* More Format

* Delete Prenote Messages

* Time out old messages

* Format

* Check controllers exist when creating new prenotes

* Prenote messages tag items (#332)

* Request Builder Functions

* Style

* Tidy Up The Api Helper

* Add To ApiHelper

* Formatting

* Fix missing constructor for ApiInterface

* Fix Method

* Status indicator tag item

* Start cancellation menu

* Cancelling Prenote Menu

* Allow controller positions to have prenote permissions

* Only allow deletion of prenotes by responsible controllers

* Sending prenote messages

* Formatting

* Srd improvements

* Airfield ownership

* Airfield ownership

* More optimise

* Format

* Fix compile warnings in utils

* Testing utils

* Updater compiler warnings

* Tweaks

* Tidy up some headers

* Pragma once in source files

* Intention things

* More tweaking

* Under 200

* More tweaks

* More tweak

* More tweak

* Last 10

* Core builds

* More test things

* Test tweaking

* At least it builds

* Tests pass

* Formatting

* More format

* Mocks in precompiled headers

* Disable tidy for this one

* Tweak

* Go to Wall

* Update build.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants