Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json_StringIsLargeNumber matching invalid numbers #66

Open
timhall opened this issue Aug 11, 2017 · 1 comment
Open

json_StringIsLargeNumber matching invalid numbers #66

timhall opened this issue Aug 11, 2017 · 1 comment
Labels
bug

Comments

@timhall
Copy link
Member

timhall commented Aug 11, 2017

See VBA-tools/VBA-Web#273, VBA-tools/VBA-Web#274

The function json_StringIsLargeNumber checks only if the string contains '0', 'E', 'e' or '.' characters to say if it's a number or not. So the string code like this one 012345678901234567890 is recognized as a valid Json number which in reality is not.
@timhall timhall added the bug label Apr 6, 2018
@jeffshieldsdev
Copy link

jeffshieldsdev commented Jun 18, 2019 •
edited

I have a string "............" which this function is returning True for. I'm going to update the function to explicitly check for a number character in addition to .|E|e

@Nick-vanGemeren Nick-vanGemeren mentioned this issue Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timhall @jeffshieldsdev