Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins where root folder does not match slug #200

Closed
5 of 8 tasks
cschol opened this issue Jan 25, 2018 · 9 comments
Closed
5 of 8 tasks

Plugins where root folder does not match slug #200

cschol opened this issue Jan 25, 2018 · 9 comments

Comments

@cschol
Copy link
Collaborator

cschol commented Jan 25, 2018

On Windows:

  • CastleRocktronics (folder: CastleRocktronics-0.5.0)
  • s-ol (folder: solmods)
  • SonusModular (folder: sonusmodular)
  • StellareModular (folder: Stellare-Modular)
  • Valley Free (folder: ValleyRackFree)
  • JE (folder: VCVRack-plugin-JE-0.5.0-Win)
  • IO-Simple (folder: VCVRack-Simple)
  • Vult (folder: VultModules)
@AndrewBelt
Copy link
Member

Thanks, will come in handy.

Just brainstorming, perhaps once a centralized build system #6 is configured, it should be required to have source built by them for the open-source plugins. This would reduce malware, since a particular hash could be pulled from the GitHub repo.

@cschol
Copy link
Collaborator Author

cschol commented Jan 25, 2018

Yeah, you will need to keep the build system up with dependencies for all plugins. There is currently one (PulsumQuadratum-rtlsdr), which I can't get to build on Windows from source. Still trying to figure out if it is a source issue or just a missing dependency.

@KieranPringle
Copy link
Contributor

PR opened here: #256

@AndrewBelt
Copy link
Member

AndrewBelt commented Feb 10, 2018

@cschol Thanks! Do you want to be on the Repair team?

@cschol
Copy link
Collaborator Author

cschol commented Feb 10, 2018

@AndrewBelt Sure. Wherever you need help.

@wizardishungry
Copy link
Contributor

@cschol PulsumQuadratum-rtlsdr not building is because the dependencies aren't packaged as submodules yet - bongozone/vcvrack-rtlsdr#31

@david-c14
Copy link

Does it cause a problem if the root folder doesn't match the slug.

Because I've only just started, I can easily move my repository if you prefer

@AndrewBelt
Copy link
Member

Actually I think this issue is obsolete since it's a build issue and will be solved when the Build Team builds everything themselves.

@david-c14
Copy link

ok, thanks. Sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants