Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppeteer: before closing, wait for the request to finish while testing html examples. #497

Open
mathieuLivebardon opened this issue Jan 17, 2023 · 1 comment
Open

Puppeteer: before closing, wait for the request to finish while testing html examples. #497

mathieuLivebardon opened this issue Jan 17, 2023 · 1 comment
Assignees
@valentinMachado
Labels
priority-low test @ud-viz This issue requires changes in the mono repo wip

Comments

@mathieuLivebardon
Copy link
Contributor

Uncompleted requests may raise an Error (Error: net::ERR_ABORTED).

Links :
https://stackoverflow.com/questions/56530424/puppeteer-wait-for-request-to-finish-after-dropdown-selection
https://stackoverflow.com/questions/59771068/puppeteer-wait-for-network-requests-to-complete-after-page-select
@mathieuLivebardon mathieuLivebardon changed the title Puppeteer: wait for request to finish when test examples html Puppeteer: wait for request to finish when test examples html before close Jan 17, 2023
@mathieuLivebardon mathieuLivebardon changed the title Puppeteer: wait for request to finish when test examples html before close Puppeteer: before closing, wait for the request to finish while testing html examples. Jan 17, 2023
@valentinMachado valentinMachado self-assigned this Mar 16, 2023
@valentinMachado valentinMachado linked a pull request Mar 16, 2023 that will close this issue
497 puppeteer before closing wait for the request to finish while testing html examples #565
Closed
@valentinMachado
Copy link
Contributor

valentinMachado commented Mar 17, 2023 •
edited
Loading

I tried something but did not succeed...
Should we close this ?

EDIT: one solution could be to write a dedicated test for each example

@mathieuLivebardon mathieuLivebardon mentioned this issue Mar 21, 2023
Closed
@valentinMachado valentinMachado added the @ud-viz This issue requires changes in the mono repo label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinMachado valentinMachado

Labels
priority-low test @ud-viz This issue requires changes in the mono repo wip
Projects
None yet
Milestone
No milestone
2 participants
@valentinMachado @mathieuLivebardon