497 puppeteer before closing wait for the request to finish while testing html examples #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am giving up on this... I tried when page.goto to wainUntil networkidle0 but it's appears that when a page is rendering an animated element like a canvas this event is never triggered. So instead I tried with the flag waitUntil domDocumentload but I have to define myself when all request have been done, like ones which can be embeded inside an iframe which I did not resolve with the PendingXHR package not catching these pending xhr. So for now we could let the CI just connect to the page and wait a certain amount of time like it's done |
valentinMachado
deleted the
497-puppeteer-before-closing-wait-for-the-request-to-finish-while-testing-html-examples
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR instead of waiting an hardcoded duration after opening the page ensure that: