Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links online doc #562

Open
valentinMachado opened this issue Mar 14, 2023 · 3 comments
Open

Fix links online doc #562

valentinMachado opened this issue Mar 14, 2023 · 3 comments
Assignees
Labels
documentation priority-low @ud-viz This issue requires changes in the mono repo wip

Comments

@valentinMachado
Copy link
Contributor

valentinMachado commented Mar 14, 2023

When jsdoc is generating the online documentation based on markdown files (ones in that repository) relative path in markdown files (which are correct in a github environment or a vscode environment) are broken in html files generated.

Since we want our online documentation (html generated) and our github/desktop environment (markdown files) to resolve these path, one approach could be to put URL everywhere (with some hack required).

Maybe is it possible to fix this problem by configuring jsdoc html generation ?

This could be also an opportunity to develop a CI test which could generate the online doc and then parse it clicking every link, to check online dead links (could already exists)

related #552
same problem here 2016

@valentinMachado valentinMachado added clean up Code has to be modifed but not functionally documentation labels Mar 14, 2023
@valentinMachado
Copy link
Contributor Author

https://www.npmjs.com/package/dead-link => introduce 13 high + 2 critical vulnerabilities
https://www.npmjs.com/package/dead-link-checker => introduce 4 moderate vulnerabilities

which for the both are not fixable with npm audit fix

@valentinMachado
Copy link
Contributor Author

valentinMachado commented Mar 20, 2023

found one npm package checking html url but we are force to use 0.6.7 version because newer version have vulnerabilities

EDIT 1: the version 0.6.7 do not propose the SiteChecker class and seems to not working properly, since url cannot be parsed. I tried with the latest version and the SiteChecker class which appear to work so for now I'll implement this solution and wait for vulnerabilities to be fix

EDIT 2: ongoing

@valentinMachado
Copy link
Contributor Author

valentinMachado commented Mar 20, 2023

A first solution for the CI test have been implemented on this branch

It just check internal links and found 391 broken links.

npm audit report

robots-txt-guard <1.0.2
Severity: high
robots-txt-guard Inefficient Regular Expression Complexity vulnerability - GHSA-6g33-8w2q-4hxv
fix available via npm audit fix --force
Will install broken-link-checker@0.6.7, which is a breaking change
node_modules/robots-txt-guard
broken-link-checker >=0.7.0
Depends on vulnerable versions of robots-txt-guard
node_modules/broken-link-checker

2 high severity vulnerabilities

You can test this CI by running node ./bin/checkBrokenLinkDocSite.js /!\ this command will generate the doc html which you don't want to commit

@valentinMachado valentinMachado self-assigned this Mar 20, 2023
@valentinMachado valentinMachado added enhancement wip @ud-viz This issue requires changes in the mono repo and removed clean up Code has to be modifed but not functionally enhancement labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation priority-low @ud-viz This issue requires changes in the mono repo wip
Projects
None yet
Development

No branches or pull requests

1 participant