Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.8.0 ? #244

Open
san-slysz opened this issue Jan 26, 2022 · 2 comments
Open

Release v0.8.0 ? #244

san-slysz opened this issue Jan 26, 2022 · 2 comments

Comments

@san-slysz
Copy link

Branch 'main' received a commit named 'v0.8.0 alpha' (745a76b) on march 2021.
In a few tickets @stevenvachon you mention that we should try v0.8, but from a NPM point of view, last release is v0.7.8. I also see some additional commits on main afterwards.

I'd like to try your last commits as I want to try that on a website

  • in https (Error: Unhandled Rejection. Error: unable to verify the first certificate)
  • that requires an authentication (adding an header to crawler calls could do)

As stated here, #33 (comment) I was wondering if you could consider releasing a v0.8.0. so we can give it a shot? If not, could you help me either retrieve it in a way where I'd be able to try it ?

I tried retrieving git+https://github.com/stevenvachon/broken-link-checker.git#ce9e116590b63d23687f9eb403ab773e60f4fcf1 in a package.json but encounter issues that makes me think that it was not the best approach.

@leviwheatcroft
Copy link

If you want to try it out, you need to build the package locally. In yarn this looks like thing like the following, suppose my project folder is /home/levi/git/my-project, I'm using yarn but you can do the same with npm.

cd /home/levi/git
git clone https://github.com/stevenvachon/broken-link-checker.git
cd broken-link-checker
yarn
yarn build
yarn link
cd ../my-project
yarn link broken-link-checker

I didn't get very far with this though. There's some undocumented stuff to figure out.

For example, the docs say you can siteChecker.enqueue('https://foo.com', customData) but that complains about the url, you need to siteChecker.enqueue(new URL('https://foo.com'), customData). I ran into other weirdness after that and gave up. It's an alpha version after all.

@scotty6435
Copy link

This module is still vulnerable to https://nvd.nist.gov/vuln/detail/CVE-2021-3807 because 0.8.0 still hasn't been released to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants