Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/document/make-configurable the role of the pop up dialog #785

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

EricBoix
Copy link
Contributor

@EricBoix EricBoix commented Jan 11, 2024

On starting page, a popup asks for some confirmation "of map reloading" (the question asked in "french",
ooops, goes "Voulez-vous recharger le plan ?").
The purpose of the question is not documented : in which way is the behavior of the application
changed depending on the answer given ?

Note: it seems the behavior is Chrome/Firefox dependent.

How to improve things (from quick and dirty to clean way)

  1. remove this PITA pop up
  2. document (in the UI so the user does understand) the purpose of the question
    In fact the question should be "Voulez-vous recharger la position du plan de coupe?"
    which in english goes something like "Do you want to restore the clipping plane position to its modified position or should the default position be restored?" (make the question shorter and clearer of course)
  3. make that popup an option (as creation stage) that is controlled by the caller
  4. THE RECOMMENDABLE WAY: Remove the pop-up AND instead provide a
    "reset position" button within the "Clipping plane" tab entry of the widget.

Additionally, document (source level) what the quad object is for (a flat plane that "materializes" the clipping plane position).

@EricBoix EricBoix changed the title Update index.js Fix/document/make-configurable the role of the pop up dialog Jan 11, 2024
@mathieuLivebardon
Copy link
Contributor

Nice !
That PR opens the discussion on the use of localStorage in our packages. There is a lack of documentation to help us understand how to handle it properly (in particular, how to delete or disable it correctly).

@mathieuLivebardon mathieuLivebardon mentioned this pull request Jan 11, 2024
2 tasks
Copy link
Contributor

@mathieuLivebardon mathieuLivebardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Read more here

@mathieuLivebardon mathieuLivebardon merged commit 9eb540c into master Jan 11, 2024
3 checks passed
@LorenzoMarnat LorenzoMarnat deleted the Point-cloud-vizualizer-remove-confirm branch January 11, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants