Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fasta --disambiguate feature request #103

Open
mmelendrez opened this issue Mar 25, 2016 · 9 comments
Open

fasta --disambiguate feature request #103

mmelendrez opened this issue Mar 25, 2016 · 9 comments
Assignees
Labels

Comments

@mmelendrez
Copy link
Member

Can we build an option to 'force' permutations? I know we set an upper boundary of 100 which I still think is good - but when recreating a 'quasispecies' and it tells me it'll create 128 permutations of the sequence because it has 7 ambiguities - I kind of do what to recreate them to look at the theoretical population.

@averagehat
Copy link
Contributor

We could do either/both of:
a) let the user set the upper bound themselves (this would require re-running the script in cases like this)
b) prompt the user with [Y/n] to see if they want to create all permutations (this might be annoying if you are doing a lot of reads with many permutations)

@mmelendrez
Copy link
Member Author

I like both options - I'd probably use the prompt version but I get that this would be annoying if there were many sequences you had to do this with. Could create a flag --prompt which, when added to the script, turns prompting on? Otherwise the PI could go and change --upper bound [digit]. You could also build in a memory warning with a continue [Y/n]?

@mmelendrez
Copy link
Member Author

Ah additionally - I can't remember if we'd talked about this - but 'if' in the alignment that is given to the script there is a sequence that doesn't have ambiguities (because that just happened to me so I know it'll happen with other investigators) it should skip the sequence (obviously) BUT still add it to the final fasta output.

@necrolyte2
Copy link
Member

I like the idea of default is to just prompt every time it goes over certain amount or you can increase the limit

--no-prompt
--max-permutations

@averagehat
Copy link
Contributor

@mmelendrez does it currently not output the fasta sequence if it isn't ambiguous?

@necrolyte2
Copy link
Member

I thought it would, but now curious

@mmelendrez
Copy link
Member Author

It did not in this last run I did

@mmelendrez
Copy link
Member Author

I only got the sequences back that had ambiguities. It spit back out the one it could not disambiguate but I had another sequence in there that had no ambiguities...here let me find the fasta and I'll attach

@mmelendrez
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants