Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new gamespeed definitions #7

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add new gamespeed definitions #7

wants to merge 3 commits into from

Conversation

VDuchauffour
Copy link
Owner

@VDuchauffour VDuchauffour commented Sep 3, 2023 •
edited

What does this PR do?

This PR adds 2 gamespeeds: epic and marathon. It's similar to RFC DoC. HUV are scaled.

Remaining tasks

  • Refacto Asset/Python/Victory.py to remove hard-coded HUV values and adapt them to game speed.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

@VDuchauffour VDuchauffour added the enhancement New feature or request label Sep 3, 2023
@VDuchauffour VDuchauffour added enhancement New feature or request and removed enhancement New feature or request feature labels Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@VDuchauffour