Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app name from library resources #58

Closed
trupizzza opened this issue Dec 15, 2017 · 2 comments
Closed

Remove app name from library resources #58

trupizzza opened this issue Dec 15, 2017 · 2 comments

Comments

@trupizzza
Copy link

I think it's better to remove resources such as app_name from the library, because it can cause clashes with app's own app_name resource.
If someone uses app_name resource value (especially in layout, which was in my case), he will see ScrollGalleryView instead of his own app name.

Library has two res files which contains app_name string:
ScrollGalleryView/library/src/main/res/values-ru/strings.xml
ScrollGalleryView/library/src/main/res/values/strings.xml

@VEINHORN
Copy link
Owner

Hi @trupizzza . Thank you for the nice idea. 👍 Can you please create a pull request if you have some free time?

@trupizzza
Copy link
Author

@VEINHORN Of course!
Btw, there are many users encountered a problem with memory overflow using Picasso or Glide - discovering that problem now.
I'll let you know if I solve it - I have some thoughts about these errors in terms of Glide, Piccasso could be fixed in the same way

trupizzza pushed a commit to trupizzza/ScrollGalleryView that referenced this issue Dec 17, 2017
trupizzza pushed a commit to trupizzza/ScrollGalleryView that referenced this issue Dec 17, 2017
trupizzza pushed a commit to trupizzza/ScrollGalleryView that referenced this issue Dec 17, 2017
VEINHORN added a commit that referenced this issue Jan 11, 2018
#58: app name removed from library resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants