Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blink screen heartbeat based on ROS connection #44

Merged
merged 1 commit into from Feb 18, 2024

Conversation

karmanyaahm
Copy link
Collaborator

@karmanyaahm karmanyaahm commented Feb 11, 2024

PR Summary

PR Link: #44

Description

The heartbeat on the screen now only turns on when ROS is connected.

Reviewers


Changelog

  • Serial informs global screen object when every time it receives a new message
  • Screen class keeps track of the time of last message
  • If there was a message within the last 1 second, blink heartbeat, else disable heartbeat

Reviewer Guide

See Changelog

Testing

Automatic

none

Manual

video

Documentation

none

Checklist

  • Confirmed all tests pass on a clean build
  • Added reviewers in Github
  • Posted PR Summary to Discord PR's Channel
  • Ran uncrustify on any modified C++ files
  • Ran Colcon Lint for any modified CMakeLists.txt or Package.xml

Copy link
Collaborator

@MaxxWilson MaxxWilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxxWilson MaxxWilson merged commit 79b133e into VEXU-GHOST:develop Feb 18, 2024
@maxx
Copy link

maxx commented Feb 18, 2024

@MaxxWilson hey guys - i'm getting copied on all of your issues here for some reason. I'm not involved in the project obviously. would be nice to be removed so I don't need to email filter -- I have a lot of github alerts that I do need to see :)

@MaxxWilson
Copy link
Collaborator

@MaxxWilson hey guys - i'm getting copied on all of your issues here for some reason. I'm not involved in the project obviously. would be nice to be removed so I don't need to email filter -- I have a lot of github alerts that I do need to see :)

Oh my! I am so sorry about that. Will handle right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants