Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"select all" issue - limit columns in strategy panel workspace #246

Closed
2 tasks done
jernestmyers opened this issue Sep 23, 2022 · 0 comments · Fixed by #247
Closed
2 tasks done

"select all" issue - limit columns in strategy panel workspace #246

jernestmyers opened this issue Sep 23, 2022 · 0 comments · Fixed by #247
Assignees

Comments

@jernestmyers
Copy link
Member

jernestmyers commented Sep 23, 2022

This issue will be handled when the new CheckboxTree in CoreUI replaces the existing WDKClient version. The plan is outlined below:

  • give user information of columns selected and the maximum columns allowed. open to ideas on the verbiage:

    • 35 columns selected (out of 100 columns allowed)
    • 35 out of a maximum 100 columns selected
    • other...
  • use a determined maxColumnsAllowed prop/data to disable the "Update Columns" button when selected columns exceeds maxColumnsAllowed

    • this will be handled by the consumer of the new CheckboxTree
    • the idea is to allow select all but the button to execute the update will be disabled; the aforementioned message will give the user the information as to why the button is disabled and how to remedy the issue.
    • by still allowing select all, experienced users may be able to more quickly select things they want by first doing a "select all" then deselecting things

The UI work outlined below will be handled in #248

  • remove the "Update Columns" button from the top of the modal and the treeLinks from the bottom of the modal
  • ensure that the newly-created "columns selected" message, the treeLinks, and the search box remain fixed at the top of the modal, and ensure that the "Update Columns" button remains in view at the bottom of the modal
    • only scroll the treeSection
  • unify the tooltips used in the treeSection and the "Update Columns" button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant