Limit columns added to strategies panel table #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that I changed the tooltip verbiage to read
In our scrum , "Please select fewer than 80 columns" was suggested, but since 80 columns is allowable, I tweaked the verbiage accordingly. |
dmfalke
approved these changes
Oct 13, 2022
Comment on lines
87
to
101
| const updateButton = ( | ||
| <button | ||
| type="button" | ||
| className="btn" | ||
| disabled={areMaxColumnsExceeded ? true : false} | ||
| onClick={() => { | ||
| if (columnsDialogSelection) { | ||
| requestColumnsChoiceUpdate(columnsDialogSelection, question.urlSegment) | ||
| } | ||
| showHideAddColumnsDialog(false); | ||
| }} | ||
| > | ||
| Update Columns | ||
| </button> | ||
| ); |
There was a problem hiding this comment.
Indentation here is a little off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #246
Follow up work that improves the UI of the modal will be handled when replacing the existing WDKClient
CheckboxTreewith the new version from CoreUI, as outlined in #248.