Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computes refactor #88

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Computes refactor #88

merged 7 commits into from
Feb 28, 2024

Conversation

d-callan
Copy link
Member

@d-callan d-callan mentioned this pull request Feb 26, 2024
Merged
asizemore
asizemore reviewed Feb 27, 2024
View reviewed changes
R/method-correlation.R Outdated Show resolved Hide resolved
asizemore
asizemore reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@asizemore asizemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To summarize, removed data.table correlation methods, and updated some utility functions

R/method-correlation.R Show resolved Hide resolved
R/method-correlation.R Outdated Show resolved Hide resolved
@d-callan d-callan merged commit 2a8bf78 into master Feb 28, 2024
0 of 5 checks passed
@d-callan d-callan deleted the computes-refactor branch February 28, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asizemore asizemore asizemore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d-callan @asizemore