Update data accessibility info in Study details & Download tabs, specifying that access requests are pending

[danicahelb]

Related to: #1172 and VEuPathDB/EbrcWebsiteCommon#143

Discussed in 5/20/2022 EDA UX meeting. We will add responsive messaging on the download and study details tabs, immediately below the tabs (above all download buttons and links).

We are currently differentiating (1) users who were not logged in / did not have access from (2) users who had access.

In this ticket, we want to differentiate a third group: (3) users who submitted a request FOR A PROTECTED STUDY but the request is still pending.

For users whose access requests are pending (relevant to protected studies only):

Your data access request is pending.

Notes:
- For public studies, anyone can download the data so we don't need verbiage pending requests.
- For controlled studies, access requests are approved immediately upon submission and do not need verbiage for pending requests.

[dmfalke]

fyi: #1143 (comment)

[aurreco-uga]

in fut (steve, dave and i) on Jan 5 2023, we propose the following:
(1) when the user is not approved to access a study, simplify the current verbiage as:
"To download data please request access. Data will be available .....l."
(2) when clicking on the "request access" link, we go to the request form straight (do not show current popup) or go to the login page if a guest user and from there to the request form.
(3) use the current endpoint permissions to find out if a user has a pending request to access a study:
( api change to be agreed upon)
/eda/permissions/
{ actionAuthorization: {.....}
requestPending: true
isManager = false
isUserStudy....
.... }
(4) when the user has already submitted a request and the request is pending,
(4.1) use a new endpoint to grab the request content and show the form filled in :
(endpoint to be agreed upon)
/eda/dataset-request-form?datasetId=DS_fe95d702c3
(4.2) add some verbiage in the request form: eg: "you have a pending request... this form cannot be edited at this point". This UX will evolve, when the dashboard enables Outreach to unlock a request, which will enable a user to modify a request.

the backend part in (3) and (4) is in VEuPathDB/service-dataset-access#55

[aurreco-uga]

In addition to the above Danica notices:

• for prerelease studies we need to get rid of the sentence (there is a banner already)

[danicahelb]

Just to clarify (1): Update the verbiage as follows:

Data Accessibility: Protected
To download data please request access. Data will be available upon study team review and approval.

Data Accessibility: Controlled
To download data please request access. Data will be available upon study team review and approval.

Data Accessibility: Public
Data downloads for this study are public. Data are available without logging in.

Data Accesibility: Prerelease
Data downloads for this study are not yet available on ClinEpiDB.

[danicahelb]

Would the current plan mean this ticket is obsolete?

VEuPathDB/EbrcWebsiteCommon#127

[rwiecknd]

It appears the backend is ready to support this.

[aurreco-uga]

@danicahelb i think the answer is no.. not obsolete

[danicahelb]

related to VEuPathDB/EbrcWebsiteCommon#127

[chowington]

Blocked by VEuPathDB/service-dataset-access#57

[chowington]

Just to clarify (1): Update the verbiage as follows:

Data Accessibility: Protected To download data please request access. Data will be available upon study team review and approval.

Data Accessibility: Controlled To download data please request access. Data will be available upon study team review and approval.

Data Accessibility: Public Data downloads for this study are public. Data are available without logging in.

Data Accesibility: Prerelease Data downloads for this study are not yet available on ClinEpiDB.

Hi Danica, do we want the Prelease verbiage to mention ClineEpi specifically? I thought that was something we were avoiding due to code being used in multiple sites

[danicahelb]

good catch @chowington! you can say Data downloads for this study are not yet available on this website.

[chowington]

Not yet done actually---waiting for a review on #1592

[danicahelb]

Hey @chowington, the updates are appearing on the Downloads tab but NOT on the View Study Details tab

• Please implement changes on the study details tab as well

Also, pre-release studies does not show what we intended (maybe because changes have not been made to study details page:

Data Accesibility: Prerelease 
Data downloads for this study are not yet available on this website.

Also, sorry I messed up in writing this ticket. For controlled studies, the verbiage should be:

Data Accessibility: Controlled
To download data please request access. Data will be available immediately after submitting the request.

• Please update the verbiage for controlled studies

[chowington]

Fixed by #1676

[SheenaTomko]

@danicahelb, this should now be ready for qa again

[danicahelb]

looks perfect, thanks @chowington