Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Only show Management Dashboard button for user datasets" #1032

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Apr 19, 2024

Reverts #1003

This logic is not correct. If anything, we only want to show the button if a study has any access restrictions.

@dmfalke
Copy link
Member Author

dmfalke commented Apr 20, 2024

Force-merging so this can get to qa asap

@dmfalke dmfalke merged commit 3019138 into main Apr 20, 2024
1 check passed
@dmfalke dmfalke deleted the revert-1003-eda-management-button-only-user-datasets branch April 20, 2024 03:02
@aurreco-uga
Copy link
Member

frankly i would just fix the bug for now.. so it only shows when needed..
danica describes a situation when it will be needed in public studies (in qa sites providers wont be able to see other providers studies even if public)
but that might not be the case for a while and i rather eliminate clutter.. and will be clue on how things are working.

@dmfalke
Copy link
Member Author

dmfalke commented Apr 22, 2024

in qa sites providers wont be able to see other providers studies even if public

I don't really understand this. Who exactly would it be "public" for?

Anyhow, I will work on a fix for not showing the button for public studies soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants