Add maps sharing prefix #1050
Merged
Add maps sharing prefix #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmfalke
requested review from
bobular and
jernestmyers
and removed request for
bobular
jernestmyers
approved these changes
Apr 25, 2024
bobular
reviewed
Apr 26, 2024
| siteName: projectConfig?.displayName ?? '', | ||
| }} | ||
| sharingUrl={''} | ||
| sharingUrlPrefix={'/maps'} |
There was a problem hiding this comment.
What handles the /maps/<analysisId> route?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1048
This PR allows a
sharingUrlPrefixto be defined for the map app. It allows the prefix to be undefined, in which case it uses a standard application url.While working on this, I noticed that the standard EDA workspace has a hardcoded url. Thus, I hardcoded the url for the map. I will open a new issue to make that configurable, and we can decided if it's worth the effort.
ETA The issue is #1051.