Use a Set for id lookup #1088
Merged
Use a Set for id lookup #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Viz picker is now usable |
|
Sweet! How would you like me to test? Just general testing to make sure it works on other datasets? Or would you like me to test it on the super big dataset? Happy to do whatever would be most helpful! |
|
I think the main thing is to test that the test being performed is still correct |
dmfalke
added a commit
that referenced
this pull request
Jul 9, 2024
dmfalke
added a commit
that referenced
this pull request
Jul 10, 2024
* Display invalid filters so they can be removed (#1124) * Display invalid filters so they can be removed * Update tooltip verbiage (cherry picked from commit 90cfd8f) * Add banner related to fixing variable identifiers in mbio (#1128) (cherry picked from commit 51f3d57) * Use a Set for id lookup (#1088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to address some inefficiencies when a study has >120,000 variables.
Changes include:
Setfor lookups, rather thanArray.prototype.includesFor now, we will only support 30K variables.