Remove console.error and report non-success responses #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jernestmyers
approved these changes
May 14, 2024
|
@jernestmyers I made a few changes since your review, and I've more thoroughly tested it. Let me know if you have questions. |
jernestmyers
approved these changes
May 14, 2024
dmfalke
added a commit
that referenced
this pull request
May 14, 2024
* Remove console.error and report non-success responses * Remove unused module * Use a getter to allow for dyanmic access to callback (cherry picked from commit b2458f0)
dmfalke
added a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091
This PR includes the following:
onNonSuccessResponse, so we can lazily callFetchClient.setOnNonSuccessResponseconsole.errorcalls