Remove console.error and report non-success responses (#1092)

packages/libs/http-utils/src/FetchClient.ts

@@ -58,16 +58,19 @@ export abstract class FetchClient {
   protected readonly baseUrl: string;
   protected readonly init: RequestInit;
   protected readonly fetchApi: Window['fetch'];
-  protected readonly onNonSuccessResponse: FetchApiOptions['onNonSuccessResponse'];
   // Subclasses can set this to false to disable including a traceparent header with all requests.
   protected readonly includeTraceidHeader: boolean = true;
+  protected get onNonSuccessResponse() {
+    return this._onNonSuccessResponse ?? FetchClient.onNonSuccessResponse;
+  }
+
+  private readonly _onNonSuccessResponse: FetchApiOptions['onNonSuccessResponse'];
 
   constructor(options: FetchApiOptions) {
     this.baseUrl = options.baseUrl;
     this.init = options.init ?? {};
     this.fetchApi = options.fetchApi ?? window.fetch;
-    this.onNonSuccessResponse =
-      options.onNonSuccessResponse ?? FetchClient.onNonSuccessResponse;
+    this._onNonSuccessResponse = options.onNonSuccessResponse;
   }
 
   /**

packages/libs/user-datasets/src/lib/Service/api.ts

@@ -91,16 +91,15 @@ export class UserDatasetApi extends FetchClientWithCredentials {
           const response = JSON.parse(xhr.response);
           dispatchUploadProgress && dispatchUploadProgress(null);
           dispatchPageRedirect && dispatchPageRedirect(response.datasetId);
-        } catch (error) {
+        } finally {
           dispatchUploadProgress && dispatchUploadProgress(null);
-          console.error(error);
         }
       }
       if (xhr.readyState === XMLHttpRequest.DONE && xhr.status >= 400) {
         const error = new Error(xhr.response);
         dispatchUploadProgress && dispatchUploadProgress(null);
         dispatchBadUpload && dispatchBadUpload(String(error));
-        console.log(error);
+        this.onNonSuccessResponse?.(error);
       }
     });