Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New optional Mesa inline table behaviour using tooltips #1115

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

bobular
Copy link
Member

@bobular bobular commented Jun 21, 2024

Note this targets the ongoing orthogroup branch.

The default Mesa behaviour when options.inline is true, is for cell contents to be truncated so the rows are equal height. Clicking on the rows expands them to show the full contents.

This wasn't acceptable for ortho, where the tree and table alignment is messed up by expanding rows. (Also browser scroll-to behaviour is unpredictable and you can't easily find the row you expanded.)

With this PR there's a new configuration option: inlineUseTooltips which removes the click behaviour and adds tooltips to all table cells.

It would be nice to do this for
a) only cells with content
b) only cells that overflow

but neither are economical to implement at this time.

Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if we're using inline=true anywhere? I wouldn't be surprised if this was a feature that never got used. Clicking to expand generally seems bad.

@bobular
Copy link
Member Author

bobular commented Jun 24, 2024

I'm using it here!
It was a useful way to get fixed-height rows. Until someone clicked on them of course...

@bobular
Copy link
Member Author

bobular commented Jun 24, 2024

I'm going to merge to orthogroup-tree-table. Going to be off grid for a few days and it would be nice to get this on the feature site.

@bobular bobular merged commit e7abcb9 into orthogroup-tree-table Jun 24, 2024
1 check passed
@bobular bobular deleted the mesa-inline-changes branch June 24, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants