Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network node clicking events #1130

Merged
merged 4 commits into from
Jul 15, 2024
Merged

network node clicking events #1130

merged 4 commits into from
Jul 15, 2024

Conversation

moontrip
Copy link
Contributor

This will possibly address #1127. A video capture with storybook is included in the following:

networ.control.click.behaviors.mp4

@moontrip moontrip mentioned this pull request Jul 10, 2024
Closed
asizemore
asizemore approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@asizemore asizemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for making both of these changes! I really like them! I looked over the code and all looks good!

@moontrip
Copy link
Contributor Author

Thank you so much for making both of these changes! I really like them! I looked over the code and all looks good!

@asizemore Thanks 👍 I could check this with microbiome and it works fine so I will merge this 🎉

@moontrip moontrip linked an issue Jul 15, 2024 that may be closed by this pull request
Network viz: When nodes clicked, their labels should show regardless of if the label is visible #1127
Closed
@moontrip moontrip merged commit c803fc5 into main Jul 15, 2024
1 check passed
@moontrip moontrip deleted the 1127-network-node-click branch July 15, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asizemore asizemore asizemore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network viz: When nodes clicked, their labels should show regardless of if the label is visible
2 participants
@moontrip @asizemore