Return markerProps from useStandaloneMapMarkers #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobular
approved these changes
Jun 9, 2023
| @@ -85,6 +85,8 @@ import { DraggablePanel } from '@veupathdb/coreui/dist/components/containers'; | |||
| import { TabbedDisplayProps } from '@veupathdb/coreui/dist/components/grids/TabbedDisplay'; | |||
| import { GeoConfig } from '../../core/types/geoConfig'; | |||
| import Banner from '@veupathdb/coreui/dist/components/banners/Banner'; | |||
| import DonutMarkerComponent from '@veupathdb/components/lib/map/DonutMarker'; | |||
| import ChartMarkerComponent from '@veupathdb/components/lib/map/ChartMarker'; | |||
There was a problem hiding this comment.
Interested in the motivation for the rename...
Oh, I see, because of the DonutMarker SVG Icon component.
This could be a general "style guide" discussion at our next meeting maybe.
|
|
||
| const markers = useMemo( | ||
| () => | ||
| markersData?.map((marker) => |
There was a problem hiding this comment.
Purely style but markerProps is more readable?
jernestmyers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is debt related to #285 and to this conversation.