Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rounding algorithm in bubble size legend #429

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Change rounding algorithm in bubble size legend #429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d764808
change rounding algo
bobular Aug 17, 2023
73ee18a
Merge branch 'main' into bubble-legend-rounding-fix
bobular Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/libs/components/src/components/plotControls/PlotBubbleLegend.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ export default function PlotBubbleLegend({
// The largest circle's value will be the first number that's larger than
// legendMax and has only one significant digit. Each smaller circle will
// be half the size of the last (rounded and >= 1)
const legendMaxLog10 = Math.floor(Math.log10(legendMax));
const roundedOneSigFig = Number(legendMax.toPrecision(1));
const largestCircleValue =
legendMax <= 10
? legendMax
: (Number(legendMax.toPrecision(1)[0]) + 1) * 10 ** legendMaxLog10;
: roundedOneSigFig < legendMax
? roundedOneSigFig + 10 ** Math.floor(Math.log10(legendMax)) // effectively rounding up
: roundedOneSigFig; // no need to adjust - already rounded up
const circleValues = _.uniq(
range(numCircles)
.map((i) => Math.round(largestCircleValue / 2 ** i))
Expand Down