75 coreui tooltip component #932
Conversation
|
Almost ready for undrafting. The only thing I can't yet figure out is why the MesaTooltips in the Mesa header cells won't show. Any thoughts? |
…athDB/web-monorepo into 75-coreui-tooltip-component
chowington
requested review from
dmfalke and
jernestmyers
and removed request for
jernestmyers
packages/libs/wdk-client/src/Components/AttributeFilter/Histogram.jsx
Outdated
Show resolved
Hide resolved
packages/libs/wdk-client/src/Components/AttributeFilter/FieldList.jsx
Outdated
Show resolved
Hide resolved
| @@ -56,7 +53,7 @@ export default function UserDatasetStatus(props: Props) { | |||
| : 'exclamation-circle'; | |||
| const children = <Icon className="StatusIcon" fa={faIcon} />; | |||
| const visibleContent = props.useTooltip ? ( | |||
| <Tooltip content={content}>{children}</Tooltip> | |||
| <Tooltip title={content}>{children}</Tooltip> | |||
There was a problem hiding this comment.
This tooltip is still not firing off in the Status column of the My Data Sets table. I think this component just needs refactoring. I think if we render the Tooltip above the Link component, it'll work just fine. If you don't mind, could you open an issue for this and I'll do the follow up work in the VDI client branch after merging this work into it? It'll create a big enough merge conflict in that component such that it makes just as much sense for me to handle it!
There was a problem hiding this comment.
Here's the new ticket! VEuPathDB/EdaNewIssues#776
There was a problem hiding this comment.
Just a few more notes, some of which can be follow-up work. This is a big enough overhaul that we may also want to tip off some stakeholders to be on the lookout for any broken tooltips, similar to my warning re: the jquery DataTable retirement.
Fixes VEuPathDB/CoreUI#75