Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit site search titles to one line and add title attribute #941

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Limit site search titles to one line and add title attribute #941

merged 2 commits into from
Mar 18, 2024

Conversation

jernestmyers
Copy link
Member

Resolves #919

image

dmfalke
dmfalke approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but it could be useful to use a React tooltip component so that users can copy the full text. Barring that, I think this looks great.

@jernestmyers
Copy link
Member Author

Not sure, but it could be useful to use a React tooltip component so that users can copy the full text. Barring that, I think this looks great.

Yeah, I had some concerns about performance but also figured the information is still attainable in the Fields matched section. 🤷

@jernestmyers jernestmyers merged commit e989633 into main Mar 18, 2024
1 check passed
@jernestmyers jernestmyers deleted the site-search-title-truncation branch March 18, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmfalke dmfalke dmfalke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jernestmyers @dmfalke