Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newline bugfix #55

Merged
merged 1 commit into from
Oct 27, 2016
Merged

newline bugfix #55

merged 1 commit into from
Oct 27, 2016

Conversation

vahpetr
Copy link
Contributor

@vahpetr vahpetr commented Oct 24, 2016

@coveralls
Copy link

coveralls commented Oct 24, 2016

Coverage Status

Coverage remained the same at 98.077% when pulling 561fa21 on vahpetr:master into 38e66fd on VFK:master.

@VFK
Copy link
Owner

VFK commented Oct 27, 2016

@vahpetr Looks good to me. I can't really reproduce that newline bug even when i try it on Windows but i guess bug is real 😄 Thank you for your PR, i'm merging it.

@hitmanmcc
Copy link

When can we see an npm release with this bugfix? This is massively annoying and it is preventing me from automating my version bump task, because I don't want to continuously add a newline everytime I fix a bug in the app. Keep up the good work. :)

@VFK
Copy link
Owner

VFK commented Nov 18, 2016

@hitmanmcc Sorry, i was waiting for a confirmation that maybe it helps with #54 and possibly other issues but looks like no, this is something different. I published v1.6.2 to npm.

@hitmanmcc
Copy link

hitmanmcc commented Nov 23, 2016

@VFK No worries, I was just wondering when it was going to be published. Anyway, thanks for the speedy reply and even more for the speedy publication of the patch, much obliged. :)

Well, I'm sad to report that after updating I still have the issue, a newline is still getting added everytime I run the task. =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants