Reorg to support electron build config #383
Conversation
|
This helped me understand much better what is going on here and how things will be structured. If I'm understanding correctly you place your api implementation in platform/{platform-type}/api which should be based on |
|
Alright, this should be done. No real functional changes. Migrated a few more components to composition as it was convenient. Improved typescript coverage. |
| @@ -18,7 +18,8 @@ module.exports = { | |||
| chainWebpack: (config) => { | |||
| config.output.strictModuleExceptionHandling(true); | |||
| config.resolve.symlinks(false); | |||
| config.resolve.alias.set('app', path.resolve(__dirname, 'app')); | |||
| config.resolve.alias.set('@', path.resolve(__dirname, 'viame-web-common')); | |||
| config.resolve.alias.set('viame-web-common', path.resolve(__dirname, 'viame-web-common')); | |||
| config.resolve.alias.set('vue-media-annotator', path.resolve(__dirname, 'src')); | |||
There was a problem hiding this comment.
Can mark as resolved, would it make more sense for consistent language and vocabulary if we renamed ./src to ./vue-media-annotator? That way everything in it is already referred to by being the media-annotator.
There was a problem hiding this comment.
Let's do this later.
- It's common convention for the distributable package to live in src/
- This PR has already been mega-disruptive, and this change isn't necessary for the purpose of the PR.
| <template #title-right> | ||
| <export | ||
| v-if="dataset !== null" | ||
| :dataset-id="dataset._id" |
There was a problem hiding this comment.
I think you're still missing the pipelines from here?
There was a problem hiding this comment.
Argh. Right, sorry.
There was a problem hiding this comment.
Fixed in 84d2d7a
Includes another fix where the Viewer could load with stale imagery from the last dataset because I moved the data to a vuex module so it no longer gets wiped when the component dies.
Fixed with a simple loading flag. This will have to change again in the electron branch, but I'm not sure how yet.
This peels apart the girder-specific parts of the client into
platform/web-girderand leaves the main client inviame-web-common. Electron (and any future build configurations, such as a theoretical girderless client/server rewrite with flask or fastapi or something) will live inplatforms/This replicates the provide pattern with an API implementation defined in
viame-web-common/apispec.ts, such that each platform willprovide(implementation)andviame-web-common/components/Viewer.vuewillinject(implementation).This is the lowest-impact solution I could come up with. There are others. Feel free to discuss or suggest alternative approaches.