Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation (concept and input_output) #2

Merged
merged 35 commits into from
Mar 25, 2021
Merged

Conversation

Cecilia-Sensalari
Copy link
Collaborator

@Cecilia-Sensalari Cecilia-Sensalari commented Mar 9, 2021

  • concept.rst: shortened first section and restructured "explained example"
  • input_output.rst: completed file lists and descriptions
  • usage.rst: added path to output filenames to tell where they are generated, peak database description, --n-threads suggestion, description of the multi-page PDF of ortholog Ks distributions

@lohausr lohausr self-requested a review March 9, 2021 21:50
Copy link
Collaborator

@lohausr lohausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my edits and comments.

doc/source/input_output.rst Outdated Show resolved Hide resolved
doc/source/input_output.rst Outdated Show resolved Hide resolved
doc/source/input_output.rst Outdated Show resolved Hide resolved
doc/source/input_output.rst Outdated Show resolved Hide resolved
doc/source/input_output.rst Outdated Show resolved Hide resolved
doc/source/concept.rst Outdated Show resolved Hide resolved
doc/source/concept.rst Outdated Show resolved Hide resolved
doc/source/concept.rst Outdated Show resolved Hide resolved
doc/source/concept.rst Outdated Show resolved Hide resolved
doc/source/concept.rst Outdated Show resolved Hide resolved
Cecilia-Sensalari and others added 7 commits March 17, 2021 11:36
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
@Cecilia-Sensalari
Copy link
Collaborator Author

Cecilia-Sensalari commented Mar 20, 2021

  • Reorganized output files/folders list in input_output.rst
  • Described ks.tsv file format (added example figure) in input_output.rst
  • Described ELMM and LMM TSV file format (added example figures) in paralogs_analyses.rst
  • Replaced the full method descriptions in paralogs_analyses.rst with summaries; referred to the SupMat for the extended explanations. I think that here on the docs it should be more a matter of how to use them and of giving an overview instead of giving detailed and technical descriptions of how they work. Now the page feels also lighter when going through it.

Copy link
Collaborator

@lohausr lohausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more edits and comments.

doc/source/concept.rst Outdated Show resolved Hide resolved
doc/source/concept.rst Outdated Show resolved Hide resolved
doc/source/concept.rst Outdated Show resolved Hide resolved

.. figure:: _images/ortholog_distribution_peak.svg
.. figure:: _images/orthologs_distribution_trio.svg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the medians in the figure once we submit to Bioinformatics.

doc/source/concept.rst Outdated Show resolved Hide resolved
doc/source/input_output.rst Outdated Show resolved Hide resolved
doc/source/input_output.rst Outdated Show resolved Hide resolved
doc/source/input_output.rst Outdated Show resolved Hide resolved
doc/source/input_output.rst Outdated Show resolved Hide resolved
doc/source/input_output.rst Outdated Show resolved Hide resolved
Cecilia-Sensalari and others added 5 commits March 24, 2021 13:01
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
@Cecilia-Sensalari
Copy link
Collaborator Author

  • Tables updated with isopub.txt check and cross symbols
  • Removed distribution_peak_estimate parameter from expert config files
  • Applied suggestions in review
  • Added preprint citation in "How to cite us" page

Copy link
Collaborator

@lohausr lohausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small changes.

doc/source/citation_acknowledgement.rst Outdated Show resolved Hide resolved
doc/source/citation_acknowledgement.rst Outdated Show resolved Hide resolved
@@ -199,7 +198,6 @@ This is an optional configuration file that contains several \"expert\" paramete

* **logging_level**: the lowest logging/verbosity level of messages printed to the console/logs (increasing severity levels: *notset*, *debug*, *info*, *warning*, *error*, *critical*). Messages less severe than *level* will be ignored; *notset* causes all messages to be processed. [Default: "info"]
* **max_gene_family_size**: maximum number of members that any paralog gene family can have to be included in *K*:sub:`S` estimation. Large gene families increase the run time and are often composed of unrelated sequences grouped together by shared protein domains or repetitive sequences. But this is not always the case, so one may want to check manually the gene families in file ``paralog_distributions/wgd_<focal species>/<focal species>.mcl.tsv`` and increase (or even decrease) this number. [Default: 200]
* **distribution_peak_estimate**: the statistical method used to obtain a single ortholog *K*:sub:`S` estimate for the divergence time of a species pair from its ortholog distribution or to obtain a single paralog *K*:sub:`S` estimate from an anchor *K*:sub:`S` cluster or from lognormal components in mixture models (options: "mode" or "median"). [Default: "mode"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this already consistently removed everywhere? Also in the code? Might be a bit early, it's also still in the preprint.

@Cecilia-Sensalari Cecilia-Sensalari merged commit a6e4062 into master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants