-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Documentation (concept and input_output) #2
Conversation
Cecilia-Sensalari
commented
Mar 9, 2021
•
edited
edited
- concept.rst: shortened first section and restructured "explained example"
- input_output.rst: completed file lists and descriptions
- usage.rst: added path to output filenames to tell where they are generated, peak database description, --n-threads suggestion, description of the multi-page PDF of ortholog Ks distributions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my edits and comments.
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more edits and comments.
|
||
.. figure:: _images/ortholog_distribution_peak.svg | ||
.. figure:: _images/orthologs_distribution_trio.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the medians in the figure once we submit to Bioinformatics.
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more small changes.
@@ -199,7 +198,6 @@ This is an optional configuration file that contains several \"expert\" paramete | |||
|
|||
* **logging_level**: the lowest logging/verbosity level of messages printed to the console/logs (increasing severity levels: *notset*, *debug*, *info*, *warning*, *error*, *critical*). Messages less severe than *level* will be ignored; *notset* causes all messages to be processed. [Default: "info"] | |||
* **max_gene_family_size**: maximum number of members that any paralog gene family can have to be included in *K*:sub:`S` estimation. Large gene families increase the run time and are often composed of unrelated sequences grouped together by shared protein domains or repetitive sequences. But this is not always the case, so one may want to check manually the gene families in file ``paralog_distributions/wgd_<focal species>/<focal species>.mcl.tsv`` and increase (or even decrease) this number. [Default: 200] | |||
* **distribution_peak_estimate**: the statistical method used to obtain a single ortholog *K*:sub:`S` estimate for the divergence time of a species pair from its ortholog distribution or to obtain a single paralog *K*:sub:`S` estimate from an anchor *K*:sub:`S` cluster or from lognormal components in mixture models (options: "mode" or "median"). [Default: "mode"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this already consistently removed everywhere? Also in the code? Might be a bit early, it's also still in the preprint.
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>