Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.rst: mainly Nextflow config section #3

Merged
merged 5 commits into from
Mar 12, 2021
Merged

Update config.rst: mainly Nextflow config section #3

merged 5 commits into from
Mar 12, 2021

Conversation

Cecilia-Sensalari
Copy link
Collaborator

  • Nextflow config file section: listed processes and describe if they are run locally or on a cluster, added dependencies for processes
  • species parameter: added that spaces in the name are not allowed
  • plot_correction_arrows: changed default to "no"

@lohausr lohausr self-requested a review March 10, 2021 15:53
lohausr
lohausr reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@lohausr lohausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few edits.

doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
Cecilia-Sensalari and others added 2 commits March 11, 2021 17:43
@Cecilia-Sensalari @lohausr
Apply suggestions from code review
143741e 
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
Fix wgdOrtholog dependencies; improve beforeScript
0df51b9
Cecilia-Sensalari
Cecilia-Sensalari commented Mar 11, 2021
View reviewed changes
Copy link
Collaborator Author

@Cecilia-Sensalari Cecilia-Sensalari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Commited changes
  • We still need to rephrase the sentence about the number of threads and memory

doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
@Cecilia-Sensalari Cecilia-Sensalari merged commit 78dbcb2 into master Mar 12, 2021
@Cecilia-Sensalari Cecilia-Sensalari deleted the configuration_rst branch March 12, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohausr lohausr lohausr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cecilia-Sensalari @lohausr