Improve checkpoint for divergence colors provided in configuration file #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check if divergence color list in the configuration file is empty and+ check if it contains at least as many colors as the number of internal nodes in the lineage that leads to the focal species (backbone of the tree plotted in the PDF or as ASCII).
- Warns and exit if colors in configuration file field "divergence_colors" are found to be not compatible with matplotlib, the package that is going to use them later on to generate the Ks plot. E.g. misspelled colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fc_configfile.pynow warns and exits ifdivergence_colorsconfiguration file field was left empty or if the color names are not recognized by matplotlib (e.g. misspelled names)setup_correction.pynow checks whether the amount of colors provided in the configuration file fielddivergence_colorsis enough: it must be at least equal to the number of divergence nodes in the lineage that goes from the focal species back to to the second-to-last divergence node before the root (the root node is ignored because the divergence(s) at this node will not be rate-adjusted). This way there are enough colors to depict all of the divergence lines in the mixed Ks plot.