Add missing aborts after logging errors

VIDA-NYU · Apr 14, 2022 · 8904cc7 · 8904cc7
1 parent 1eaa627
commit 8904cc7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/reprounzip-vagrant/reprounzip/unpackers/vagrant/__init__.py b/reprounzip-vagrant/reprounzip/unpackers/vagrant/__init__.py
@@ -285,6 +285,7 @@ def vagrant_setup_create(args):
             logger.error("Need to install %d packages but couldn't select a "
                          "package installer: %s",
                          len(packages), e)
+            sys.exit(1)
 
     target.mkdir(parents=True)
 

diff --git a/reprounzip/reprounzip/unpackers/default.py b/reprounzip/reprounzip/unpackers/default.py
@@ -76,6 +76,7 @@ def installpkgs(args):
         installer = select_installer(pack, runs)
     except CantFindInstaller as e:
         logger.error("Couldn't select a package installer: %s", e)
+        sys.exit(1)
 
     if args.summary:
         # Print out a list of packages with their status

diff --git a/tests/check_images.py b/tests/check_images.py
@@ -195,6 +195,7 @@ def check_docker():
                     '/'.join(repository),
                     tag,
                 )
+                error = True
             else:
                 logger.info(
                     "Docker image ok: %s:%s",