Clear up the UserAgentParser->client

VIPnytt · Aug 9, 2016 · 0591feb · 0591feb
1 parent 17fd6cc
commit 0591feb
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/Parser/Directives/UserAgentParser.php b/src/Parser/Directives/UserAgentParser.php
@@ -243,8 +243,9 @@ public function export()
      */
     public function client($product = self::USER_AGENT, $version = null, $statusCode = null)
     {
-        if (isset($this->client[$product . $version . $statusCode])) {
-            return $this->client[$product . $version . $statusCode];
+        $infix = $product . $version . $statusCode;
+        if (isset($this->client[$infix])) {
+            return $this->client[$infix];
         }
         $userAgentProduct = rtrim($product . '/' . $version, '/');
         $userAgentMatch = $userAgentProduct;
@@ -255,10 +256,9 @@ public function client($product = self::USER_AGENT, $version = null, $statusCode
                 $userAgentMatch = self::USER_AGENT;
             }
         }
-        $client = new UserAgentClient($this->handler[$userAgentMatch], $this->base, $statusCode, $userAgentProduct);
-        $this->client = [
-            $product . $version . $statusCode => $client
-        ];
-        return $client;
+        // Clear cache
+        $this->client = [];
+        // Cache and return
+        return $this->client[$infix] = new UserAgentClient($this->handler[$userAgentMatch], $this->base, $statusCode, $userAgentProduct);
     }
 }