Add before prop for Search #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Дефолтную иконку выкинем что ли получается. |
|
Почему выкинем? Вон она в defaultProps, мне там нужно другую подставлять для отображения состояния контента |
|
Мало ли что кому нужно. |
|
Ок, если это не нужно библиотеке -- можно закрыть PR с таким комментарием.
|
|
Пока не понятно нужно или нет, потому что ты не пишешь что именно. Что за кейс с кнопкой очистки или отмены слева? |
|
Ты не понял, не хотелось верстать свой поиск с кнопкой отмены и очистки. |
|
Вмержишь или стоит делать кастомный поиск самому? |
NekR
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.