Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eslint-plugin-react-compiler #6920

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: add eslint-plugin-react-compiler #6920

wants to merge 1 commit into from
+66 −3

Conversation

SevereCloud
Copy link
Contributor

See errors

@SevereCloud SevereCloud added the no-stale Добавляет PR в исключения для автоматического закрытия label May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 372.66 KB (0%)
JS (gzip) 114.08 KB (0%)
JS (brotli) 93.9 KB (0%)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 300 KB (0%)
CSS (gzip) 38.26 KB (0%)
CSS (brotli) 30.79 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 16, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

👀 Docs deployed

Commit 34ca9d8

@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (e728d24) to head (34ca9d8).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6920   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         358      358           
  Lines       10882    10882           
  Branches     3589     3589           
=======================================
  Hits         9139     9139           
  Misses       1743     1743
Flag Coverage Δ
unittests 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud force-pushed the feat/add-eslint-plugin-react-compiler branch from 3f23ea6 to 2483190 Compare June 25, 2024 11:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

e2e tests

Playwright Report

SevereCloud added a commit that referenced this pull request Jun 25, 2024
@SevereCloud
fix(useMediaQueries): use context
a3bc2a3 
- see #6920

---

## Описание

React компилятор не разрешает писать в переменные за пределами хука

> Writing to a variable defined outside a component or hook is not allowed.

## Изменения

Используем контекст, вместо переменной
@SevereCloud SevereCloud mentioned this pull request Jun 25, 2024
Merged
SevereCloud added a commit that referenced this pull request Jun 25, 2024
@SevereCloud
fix(AccordionContent): mutating hook argument
fcdd5a4 
- see #6920

---

## Описание

React компилятор ругается на мутацию аргумента хука

> Mutating component props or hook arguments is not allowed. Consider using a local variable instead `react-compiler/react-compiler`

## Изменения

Переписал, чтобы линтер не ругался
@SevereCloud SevereCloud mentioned this pull request Jun 25, 2024
Merged
SevereCloud added a commit that referenced this pull request Jun 25, 2024
@SevereCloud @inomdzhon
fix(useMediaQueries): use WeakMap (#7071)
c2309f8 
- see #6920

---

## Описание

React компилятор не разрешает писать в переменные за пределами хука

> Writing to a variable defined outside a component or hook is not allowed.

## Изменения

Используем WeakMap

---------

Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
SevereCloud added a commit that referenced this pull request Jun 25, 2024
@SevereCloud
fix(AccordionContent): mutating hook argument (#7075)
4f043bd 
- see #6920

---

## Описание

React компилятор ругается на мутацию аргумента хука

> Mutating component props or hook arguments is not allowed. Consider using a local variable instead `react-compiler/react-compiler`

## Изменения

Переписал, чтобы линтер не ругался
SevereCloud added a commit that referenced this pull request Jun 25, 2024
@SevereCloud
test: use no memo
973b59b 
- see #6920

---

Используем  `use no memo` для отключения компилятора в тестах
@SevereCloud SevereCloud mentioned this pull request Jun 25, 2024
Merged
SevereCloud added a commit that referenced this pull request Jun 25, 2024
@SevereCloud
test: use no memo (#7076)
a8fd64f 
- see #6920

---

Используем  `use no memo` для отключения компилятора в тестах
SevereCloud added a commit that referenced this pull request Jun 25, 2024
@SevereCloud
fix(useExternRef): rm useMemo
eef90a5 
- see #6920

---

## Описание

Для компилятора требуется знать точные зависимости в useMemo

## Изменение

Избавился от useMemo, написал отдельный класс реализующий MutableRefObject
@SevereCloud SevereCloud mentioned this pull request Jun 25, 2024
Merged
SevereCloud added a commit that referenced this pull request Jun 26, 2024
@SevereCloud
fix(useExternRef): rm hooks
52bd39d 
- see #6920

---

## Описание

Линтер компилятора ругается на внутренности хука useExternRef

## Изменение

Избавился от хуков, написал отдельный класс реализующий EventListenerHandle
@SevereCloud SevereCloud mentioned this pull request Jun 26, 2024
Merged
SevereCloud added a commit that referenced this pull request Jun 26, 2024
@SevereCloud
fix(useEventListener): rm hooks
46fa91a 
- see #6920

---

## Описание

Линтер компилятора ругается на внутренности хука useEventListener

## Изменение

Избавился от хуков, написал отдельный класс реализующий EventListenerHandle
SevereCloud added a commit that referenced this pull request Jun 26, 2024
@SevereCloud
fix(useEventListener): rm hooks
5bb0ba4 
- see #6920

---

Линтер компилятора ругается на внутренности хука useEventListener

Избавился от хуков, написал отдельный класс реализующий EventListenerHandle
SevereCloud added a commit that referenced this pull request Jun 26, 2024
@SevereCloud
fix: add useResizeTextarea
ba38c46 
- see #6920

---

## Описание

Линтер компилятора ругается на мутации внутри Textarea, WriteBar

> Mutating a value returned from a function whose return value should not be mutated

## Изменение

Вынес общий хук useResizeTextarea
@SevereCloud SevereCloud mentioned this pull request Jun 26, 2024
Merged
SevereCloud added a commit that referenced this pull request Jun 26, 2024
@SevereCloud
fix: add useResizeTextarea (#7081)
063a85c 
- see #6920

---

## Описание

Линтер компилятора ругается на мутации внутри Textarea, WriteBar

> Mutating a value returned from a function whose return value should not be mutated

## Изменение

Вынес общий хук useResizeTextarea
@SevereCloud SevereCloud force-pushed the feat/add-eslint-plugin-react-compiler branch from 2483190 to f9fce01 Compare June 28, 2024 11:18
SevereCloud added a commit that referenced this pull request Jul 9, 2024
@SevereCloud
fix(useEventListener): rm hooks (#7078)
4a4df89 
- see #6920

---

Линтер компилятора ругается на внутренности хука useEventListener

Избавился от хуков, написал отдельный класс реализующий EventListenerHandle
SevereCloud added a commit that referenced this pull request Jul 9, 2024
@SevereCloud
fix(useExternRef): rm useMemo (#7077)
364d3cf 
- see #6920

---

## Описание

Для компилятора требуется знать точные зависимости в useMemo

## Изменение

Избавился от useMemo, написал отдельный класс реализующий MutableRefObject
@SevereCloud SevereCloud force-pushed the feat/add-eslint-plugin-react-compiler branch from f9fce01 to 70e67e6 Compare July 9, 2024 11:08
SevereCloud added a commit that referenced this pull request Jul 9, 2024
@SevereCloud
fix(ImageBase): add DevelopmentCheck
2e98bdc 
- see #6920

---

Выносим проверки в деве, чтобы не нарушать правило хуков
@SevereCloud SevereCloud mentioned this pull request Jul 9, 2024
Merged
SevereCloud added a commit that referenced this pull request Jul 9, 2024
@SevereCloud
fix(ImageBase): add DevelopmentCheck
3cd9303 
- see #6920

---

Выносим проверки в деве, чтобы не нарушать правило хуков
SevereCloud added a commit that referenced this pull request Jul 9, 2024
@SevereCloud
fix(ImageBase): add DevelopmentCheck
689bb08 
- see #6920

---

Выносим проверки в деве, чтобы не нарушать правило хуков
@SevereCloud SevereCloud force-pushed the feat/add-eslint-plugin-react-compiler branch from 70e67e6 to 34ca9d8 Compare July 9, 2024 14:12
SevereCloud added a commit that referenced this pull request Jul 9, 2024
@SevereCloud
fix(Checkbox): remove mutating ref
7f938e9 
- see #6920

---

> Mutating a value returned from a function whose return value should not be mutated

Скрываем мутацию от компилятора
@SevereCloud SevereCloud mentioned this pull request Jul 9, 2024
Merged
SevereCloud added a commit that referenced this pull request Jul 9, 2024
@SevereCloud
fix(View): add useLayoutEffectCall
7cdc68d 
- see #6920

---

> This mutates a variable that React considers immutable

Компилятор ругается на мутацию afterTransition
@SevereCloud SevereCloud mentioned this pull request Jul 9, 2024
Merged
SevereCloud added a commit that referenced this pull request Jul 10, 2024
@SevereCloud
fix(Checkbox): remove mutating ref (#7163)
e89ee53 
- see #6920

---

> Mutating a value returned from a function whose return value should not be mutated

Скрываем мутацию от компилятора
vkcom-publisher pushed a commit that referenced this pull request Jul 10, 2024
@SevereCloud @actions-user
fix(Checkbox): remove mutating ref (#7163)
8c729f3 
- see #6920
SevereCloud added a commit that referenced this pull request Jul 10, 2024
@SevereCloud
fix(ImageBase): add DevelopmentCheck (#7157)
23fab3d 
- see #6920

---

Выносим проверки в деве, чтобы не нарушать правило хуков
SevereCloud added a commit that referenced this pull request Jul 15, 2024
@SevereCloud
fix(View): add useLayoutEffectCall (#7164)
cdf2646 
- see #6920

---

> This mutates a variable that React considers immutable

Компилятор ругается на мутацию afterTransition

* refactor: call to add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-stale Добавляет PR в исключения для автоматического закрытия
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SevereCloud