[compiler] add basic support for type-checked mixed union types #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types like `int|string` can now be expressed in the type system. Every mixed union variant sets a bit flag inside TypeData. When generating the C++ code, any mixed unions become simple mixed types. Right now we only check function parameters passing and field assignments. Mixed union types are washed away in all contexts except for the phpdoc. We'll remove this restriction later, when more code will be ready to adapt for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types like
int|stringcan now be expressed in the type system. Every mixed union variant sets a bit flag inside TypeData.When generating the C++ code, any mixed unions become simple mixed types.
Right now we only check function parameters passing and field assignments. Mixed union types are washed away in all contexts except for the phpdoc. We'll remove this restriction later, when more code will be ready to adapt for this change.