Extend Spacing system #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to VKCOM/VKUI#6684
To support the case when we want to keep size groups together in the token result name. For example: sizeS -> size-s sizeXs -> size-xs size2Xs -> size-2xs size2Xs3Regular2L -> size-2xs-regular-2l size2L3Regular-3S -> size-2l-3-regular-3s
Most of them are correct for us
Coverage report
Test suite run success406 tests passing in 37 suites. Report generated by 🧪jest coverage report action from 6789b72 |
|
Привет @8coon! Приемлимо ли это? |
Sarafa2n
approved these changes
Apr 3, 2024
8coon
approved these changes
Apr 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Перед отправкой этого реквеста на ревью убедитесь, что:
npm run build:local),npm test),npm run lint), некоторые ошибки можно автоматически поправить с помощьюnpm run lint:fix,ваш pull request содержит обновления документации,
согласовали их с дизайнерами. (c Алексеем Зайцевым)
Подробнее о внесении изменений в репозиторий токенов
Описание
Основано на задаче из VKUI: VKCOM/VKUI#6684 и обсуждении VKCOM/VKUI#5928. C дизайнерами VKUI также обсудили и именно этот набор токенов решено дальше поддерживать.
spacingSizeS.2Xsи3Xsи2Xlвместе, иначе со старой логикой получалось немного странно для таких токенов.Вот пример для spacingSize2Xl
Но сразу оговорюсь, что ничего не имею против оставить как есть, просто немного не интуитивно. По тестам проверил, что больше никакие токены не меняются, регулярка изменяет только такую запись.