Add 404 page #81
Merged
Add 404 page #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2019 22:49
|
I'm so sorry ! I hadn't see the rules about prettier, and I didn't understand how it works. |
I feel so bad... I need some sleep... Sorry!
hell03610
requested changes
Oct 7, 2019
data/assets/css/pages/_404.scss
Outdated
| font-size: 1.5rem; | ||
| } | ||
|
|
||
| @media screen and (max-width: 670px) { |
There was a problem hiding this comment.
Thanks a lot for this pull request! But please sleep well :)
It is not big deal, but I have a change suggestion in this styles.
Current sass styles are "mobile first", and then there are two breakpoints for medium and large screens (you can see an example here https://github.com/VLCTechHub/VLCTechHub-site/blob/master/data/assets/css/pages/_event.scss#L32 or here
Could you change the styles so they use these general breakpoints?
(Just to let you know there are also some variables for common margin/padding values at
, for 10px, 20px, ... in rem values in case you want to try them)
hell03610
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.