Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor loans #1104

Merged
merged 7 commits into from
Feb 24, 2024
Merged

Refactor loans #1104

merged 7 commits into from
Feb 24, 2024

Conversation

VMelnalksnis
Copy link
Owner

@VMelnalksnis VMelnalksnis commented Feb 18, 2024

Split current loans into two separate entities - loans and loan payments. This allows for better loan tracking, as previously it was not possible to track multiple loans between two counterparties, only the total.

@VMelnalksnis VMelnalksnis added type:enhancement New feature or request area:ui Relating to user interface area:api labels Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Merging #1104 (2a06ee6) into master (e161d33) will decrease coverage by 0.67%.
The diff coverage is 69.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
- Coverage   69.78%   69.11%   -0.67%     
==========================================
  Files         523      539      +16     
  Lines       12757    13187     +430     
  Branches     1096     1109      +13     
==========================================
+ Hits         8902     9114     +212     
- Misses       3500     3722     +222     
+ Partials      355      351       -4     
Components Coverage Δ
API 74.07% <94.67%> (+0.27%) ⬆️
UI 61.65% <50.83%> (-1.81%) ⬇️

@VMelnalksnis VMelnalksnis force-pushed the loan_payments branch 2 times, most recently from 6396845 to 97ad9b4 Compare February 24, 2024 14:21
@VMelnalksnis VMelnalksnis marked this pull request as ready for review February 24, 2024 14:22
@VMelnalksnis VMelnalksnis merged commit 2a06ee6 into master Feb 24, 2024
10 of 12 checks passed
@VMelnalksnis VMelnalksnis deleted the loan_payments branch February 24, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api area:ui Relating to user interface type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant