Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor API client auth, add client app settings #332

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

VMelnalksnis
Copy link
Owner

Fixes #317, fixes #82.

Changes proposed in this pull request:

  • Write user modifiable configuration changes to appsettings.user.json
  • Handle API client auth using DelegatingHandler

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #332 (b52d18a) into master (d8aa4ad) will decrease coverage by 0.82%.
The diff coverage is 35.42%.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   68.55%   67.73%   -0.83%     
==========================================
  Files         232      242      +10     
  Lines        6672     6830     +158     
  Branches      467      484      +17     
==========================================
+ Hits         4574     4626      +52     
- Misses       1943     2043     +100     
- Partials      155      161       +6     
Impacted Files Coverage Δ
...alonia.Core/Configuration/OidcOptionsExtensions.cs 0.00% <0.00%> (ø)
...onia.Core/DesignTime/DesignTimeGnomeshadeClient.cs 72.63% <0.00%> (ø)
...e.Interfaces.WebApi.Client/GnomeshadeTokenCache.cs 0.00% <0.00%> (ø)
...Interfaces.WebApi.Client/TokenDelegatingHandler.cs 0.00% <0.00%> (ø)
...onia.Core/Configuration/UserConfigurationWriter.cs 15.78% <15.78%> (ø)
...lonia.Core/Authentication/AuthenticationService.cs 50.00% <25.00%> (+30.00%) ⬆️
...a.Core/Configuration/UserConfigurationValidator.cs 26.08% <26.08%> (ø)
...Core/Configuration/ApplicationSettingsViewModel.cs 29.26% <29.26%> (ø)
...de.Interfaces.Avalonia.Core/MainWindowViewModel.cs 17.26% <30.00%> (-4.87%) ⬇️
...erfaces.Avalonia.Core/Configuration/OidcOptions.cs 60.00% <60.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8aa4ad...b52d18a. Read the comment docs.

@VMelnalksnis VMelnalksnis merged commit b52d18a into master Jul 4, 2022
@VMelnalksnis VMelnalksnis deleted the feature/desktop-settings branch July 4, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor IGnomeshadeClient token management Set gnomeshade API base address from UI
1 participant