Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API health checks #347

Merged
merged 6 commits into from
Jul 13, 2022
Merged

Improve API health checks #347

merged 6 commits into from
Jul 13, 2022

Conversation

VMelnalksnis
Copy link
Owner

Changes proposed in this pull request:

  • Check the database connection, Nordigen API and OIDC providers during health check

@VMelnalksnis VMelnalksnis added type:enhancement New feature or request area:api labels Jul 13, 2022
VMelnalksnis and others added 6 commits July 13, 2022 15:24
Bumps [Microsoft.Extensions.Identity.Stores](https://github.com/dotnet/aspnetcore) from 6.0.6 to 6.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.6...v6.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Identity.Stores
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Microsoft.AspNetCore.Authentication.JwtBearer](https://github.com/dotnet/aspnetcore) from 6.0.6 to 6.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.6...v6.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Microsoft.AspNetCore.Identity.EntityFrameworkCore](https://github.com/dotnet/aspnetcore) from 6.0.6 to 6.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.6...v6.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Identity.EntityFrameworkCore
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Microsoft.EntityFrameworkCore.Tools](https://github.com/dotnet/efcore) from 6.0.6 to 6.0.7.
- [Release notes](https://github.com/dotnet/efcore/releases)
- [Commits](dotnet/efcore@v6.0.6...v6.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.EntityFrameworkCore.Tools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Microsoft.AspNetCore.Mvc.Testing](https://github.com/dotnet/aspnetcore) from 6.0.6 to 6.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v6.0.6...v6.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Mvc.Testing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #347 (486af24) into master (f9cb101) will decrease coverage by 0.07%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   67.73%   67.65%   -0.08%     
==========================================
  Files         242      246       +4     
  Lines        6830     6888      +58     
  Branches      484      487       +3     
==========================================
+ Hits         4626     4660      +34     
- Misses       2043     2065      +22     
- Partials      161      163       +2     
Impacted Files Coverage Δ
....Interfaces.WebApi/HealthChecks/OidcHealthCheck.cs 33.33% <33.33%> (ø)
...erfaces.WebApi/HealthChecks/NordigenHealthCheck.cs 70.00% <70.00%> (ø)
...erfaces.WebApi/HealthChecks/DatabaseHealthCheck.cs 72.72% <72.72%> (ø)
...terfaces.WebApi/Configuration/AuthConfiguration.cs 72.00% <100.00%> (ø)
...WebApi/HealthChecks/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
source/Gnomeshade.Interfaces.WebApi/Startup.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9cb101...486af24. Read the comment docs.

@VMelnalksnis VMelnalksnis merged commit 486af24 into master Jul 13, 2022
@VMelnalksnis VMelnalksnis deleted the feature/health-checks branch July 13, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant