Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link existing link if one exists #357

Merged
merged 2 commits into from
Jul 17, 2022
Merged

Conversation

VMelnalksnis
Copy link
Owner

Fixes #356.

Changes proposed in this pull request:

  • Search for an existing link with the same value before adding it to a transaction
  • Return 409 if a link already exists with the same value

@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:ui Relating to user interface area:api labels Jul 17, 2022
@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #357 (ced102b) into master (3298f09) will increase coverage by 0.14%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   67.32%   67.47%   +0.14%     
==========================================
  Files         247      247              
  Lines        6923     6942      +19     
  Branches      489      494       +5     
==========================================
+ Hits         4661     4684      +23     
+ Misses       2100     2090      -10     
- Partials      162      168       +6     
Impacted Files Coverage Δ
...omeshade.Interfaces.WebApi/V1_0/LinksController.cs 72.72% <33.33%> (-20.38%) ⬇️
....Core/Transactions/Links/LinkUpsertionViewModel.cs 72.00% <100.00%> (+48.19%) ⬆️
...ade.TestingHelpers/Data/Fakers/NamedEntityFaker.cs 57.14% <0.00%> (-14.29%) ⬇️
...onia.Core/DesignTime/DesignTimeGnomeshadeClient.cs 74.59% <0.00%> (+1.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3298f09...ced102b. Read the comment docs.

@VMelnalksnis VMelnalksnis merged commit ced102b into master Jul 17, 2022
@VMelnalksnis VMelnalksnis deleted the fix/transaction-links branch July 17, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api area:ui Relating to user interface type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add the same link to a different transaction
1 participant