Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve purchase editing #372

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Improve purchase editing #372

merged 3 commits into from
Jul 19, 2022

Conversation

VMelnalksnis
Copy link
Owner

Fix bug introduced in #371.

Changes proposed in this pull request:

@VMelnalksnis VMelnalksnis added type:bug Something isn't working type:enhancement New feature or request area:ui Relating to user interface labels Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #372 (52ff777) into master (6fb0ba3) will decrease coverage by 0.11%.
The diff coverage is 57.50%.

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   67.45%   67.34%   -0.12%     
==========================================
  Files         247      248       +1     
  Lines        6907     6926      +19     
  Branches      487      500      +13     
==========================================
+ Hits         4659     4664       +5     
- Misses       2087     2097      +10     
- Partials      161      165       +4     
Impacted Files Coverage Δ
...valonia.Core/DesignTime/DesignTimeDialogService.cs 0.00% <0.00%> (ø)
...de.Interfaces.Avalonia.Core/MainWindowViewModel.cs 17.14% <0.00%> (-0.13%) ⬇️
...ansactions/Purchases/PurchaseUpsertionViewModel.cs 79.01% <11.11%> (-7.10%) ⬇️
...a.Core/Transactions/Purchases/PurchaseViewModel.cs 69.51% <62.50%> (-1.92%) ⬇️
...erfaces.Avalonia.Core/DesignTime/DesignTimeData.cs 99.13% <100.00%> (-0.05%) ⬇️
...Core/Transactions/TransactionUpsertionViewModel.cs 64.19% <100.00%> (+0.44%) ⬆️
...Avalonia.Core/Transactions/TransactionViewModel.cs 72.05% <100.00%> (+0.41%) ⬆️
...ade.TestingHelpers/Data/Fakers/NamedEntityFaker.cs 57.14% <0.00%> (-14.29%) ⬇️
...ia.Core/Transactions/Purchases/PurchaseOverview.cs 86.95% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb0ba3...52ff777. Read the comment docs.

@VMelnalksnis VMelnalksnis merged commit 52ff777 into master Jul 19, 2022
@VMelnalksnis VMelnalksnis deleted the feature/purchase-editing branch July 19, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui Relating to user interface type:bug Something isn't working type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant