Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/initialization refactoring #376

Merged
merged 13 commits into from
Jul 20, 2022

Conversation

VMelnalksnis
Copy link
Owner

Fixes #358, fixes #178.

Changes proposed in this pull request:

  • Disable buttons while loading report
  • Create view models, switch to them, and then refresh them
  • Automatically close page after successful sign in

VMelnalksnis and others added 10 commits July 20, 2022 09:50
Bumps [VMelnalksnis.ISO20022DotNet](https://github.com/VMelnalksnis/ISO20022DotNet) from 0.2.2 to 0.3.0.
- [Release notes](https://github.com/VMelnalksnis/ISO20022DotNet/releases)
- [Commits](https://github.com/VMelnalksnis/ISO20022DotNet/commits/v0.3.0)

---
updated-dependencies:
- dependency-name: VMelnalksnis.ISO20022DotNet
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Swashbuckle.AspNetCore](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 6.3.2 to 6.4.0.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases)
- [Commits](domaindrivendev/Swashbuckle.AspNetCore@v6.3.2...v6.4.0)

---
updated-dependencies:
- dependency-name: Swashbuckle.AspNetCore
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Swashbuckle.AspNetCore.Annotations](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 6.3.2 to 6.4.0.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases)
- [Commits](domaindrivendev/Swashbuckle.AspNetCore@v6.3.2...v6.4.0)

---
updated-dependencies:
- dependency-name: Swashbuckle.AspNetCore.Annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@VMelnalksnis VMelnalksnis added type:bug Something isn't working type:enhancement New feature or request area:ui Relating to user interface labels Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #376 (330ea97) into master (52ff777) will increase coverage by 0.37%.
The diff coverage is 70.46%.

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   67.34%   67.71%   +0.37%     
==========================================
  Files         248      248              
  Lines        6926     6821     -105     
  Branches      500      489      -11     
==========================================
- Hits         4664     4619      -45     
+ Misses       2097     2036      -61     
- Partials      165      166       +1     
Impacted Files Coverage Δ
...aces.Avalonia.Core/Authentication/SystemBrowser.cs 0.00% <0.00%> (ø)
...alonia.Core/Configuration/OidcOptionsExtensions.cs 0.00% <0.00%> (ø)
...de.Interfaces.Avalonia.Core/MainWindowViewModel.cs 16.66% <0.00%> (-0.48%) ⬇️
....Avalonia.Core/Transactions/Loans/LoanViewModel.cs 77.41% <ø> (+0.27%) ⬆️
...ansactions/Purchases/PurchaseUpsertionViewModel.cs 78.04% <0.00%> (-0.97%) ⬇️
...e/Counterparties/CounterpartyUpsertionViewModel.cs 43.75% <43.75%> (ø)
....Core/Counterparties/CounterpartyMergeViewModel.cs 82.85% <50.00%> (+34.96%) ⬆️
...lonia.Core/Counterparties/CounterpartyViewModel.cs 67.64% <59.09%> (+26.37%) ⬆️
...alonia.Core/Products/CategoryUpsertionViewModel.cs 57.57% <66.66%> (ø)
...erfaces.Avalonia.Core/Accounts/AccountViewModel.cs 67.64% <68.75%> (+1.79%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ff777...330ea97. Read the comment docs.

@VMelnalksnis VMelnalksnis force-pushed the feature/initialization-refactoring branch from b2c5300 to 330ea97 Compare July 20, 2022 12:02
@VMelnalksnis VMelnalksnis merged commit 330ea97 into master Jul 20, 2022
@VMelnalksnis VMelnalksnis deleted the feature/initialization-refactoring branch July 20, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui Relating to user interface type:bug Something isn't working type:enhancement New feature or request
Projects
None yet
1 participant