Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant nested API routes #423

Merged
merged 4 commits into from
Aug 19, 2022
Merged

Remove redundant nested API routes #423

merged 4 commits into from
Aug 19, 2022

Conversation

VMelnalksnis
Copy link
Owner

Changes proposed in this pull request:

@VMelnalksnis VMelnalksnis added type:enhancement New feature or request area:api labels Aug 19, 2022
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #423 (d1c0216) into master (a2ea406) will decrease coverage by 0.40%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   64.75%   64.34%   -0.41%     
==========================================
  Files         251      256       +5     
  Lines        6861     6833      -28     
  Branches      535      518      -17     
==========================================
- Hits         4443     4397      -46     
- Misses       2261     2277      +16     
- Partials      157      159       +2     
Impacted Files Coverage Δ
....Core/Transactions/Loans/LoanUpsertionViewModel.cs 25.53% <0.00%> (-0.56%) ⬇️
....Avalonia.Core/Transactions/Loans/LoanViewModel.cs 77.14% <0.00%> (ø)
...a.Core/Transactions/Purchases/PurchaseViewModel.cs 69.51% <0.00%> (ø)
...a.Core/Transactions/Transfers/TransferViewModel.cs 83.01% <0.00%> (ø)
...rce/Gnomeshade.Data/Repositories/LoanRepository.cs 92.85% <ø> (+2.85%) ⬆️
...Gnomeshade.Data/Repositories/PurchaseRepository.cs 100.00% <ø> (+5.26%) ⬆️
...Gnomeshade.Data/Repositories/TransferRepository.cs 92.85% <0.00%> (-7.15%) ⬇️
...WebApi/V1_0/Transactions/TransactionsController.cs 90.59% <ø> (-4.22%) ⬇️
...ansactions/Transfers/TransferUpsertionViewModel.cs 70.88% <33.33%> (-0.91%) ⬇️
...onia.Core/DesignTime/DesignTimeGnomeshadeClient.cs 73.70% <45.45%> (-0.57%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis merged commit d1c0216 into master Aug 19, 2022
@VMelnalksnis VMelnalksnis deleted the fix/controllers branch August 19, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant