Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split PostgreSQL specific code into separate project #426

Merged
merged 4 commits into from
Aug 21, 2022

Conversation

VMelnalksnis
Copy link
Owner

Split off PostgreSQL specific code into Gnomeshade.Data.PostgreSQL project, so that is is easier to add support for other dabases, for example, SQLite.

@VMelnalksnis VMelnalksnis added type:enhancement New feature or request area:api labels Aug 21, 2022
@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #426 (5620627) into master (fbb3b5d) will increase coverage by 0.14%.
The diff coverage is 88.42%.

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   64.39%   64.54%   +0.14%     
==========================================
  Files         256      258       +2     
  Lines        6831     6836       +5     
  Branches      521      532      +11     
==========================================
+ Hits         4399     4412      +13     
+ Misses       2274     2262      -12     
- Partials      158      162       +4     
Impacted Files Coverage Δ
...igrations/20220313170407_InitialCreate.Designer.cs 100.00% <ø> (ø)
...grations/PostgreSQLIdentityContextModelSnapshot.cs 0.00% <ø> (ø)
source/Gnomeshade.Data/Identity/ApplicationUser.cs 100.00% <ø> (ø)
...nomeshade.Data/Migrations/DatabaseUpgradeLogger.cs 66.66% <ø> (ø)
...e.Data/Repositories/AccountInCurrencyRepository.cs 75.00% <ø> (ø)
.../Gnomeshade.Data/Repositories/AccountRepository.cs 100.00% <ø> (ø)
...Gnomeshade.Data/Repositories/CategoryRepository.cs 100.00% <ø> (ø)
...eshade.Data/Repositories/CounterpartyRepository.cs 90.90% <ø> (ø)
...rce/Gnomeshade.Data/Repositories/LinkRepository.cs 100.00% <ø> (ø)
...rce/Gnomeshade.Data/Repositories/LoanRepository.cs 92.85% <ø> (ø)
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis force-pushed the feat/clean-up-data branch 6 times, most recently from 30c7e6c to 743c5cd Compare August 21, 2022 09:21
@VMelnalksnis
Copy link
Owner Author

Had to fiddle with migrations, both EF and dbup, in order to retain existing migration names and not cause issues with existing server installations.

@VMelnalksnis VMelnalksnis merged commit 5620627 into master Aug 21, 2022
@VMelnalksnis VMelnalksnis deleted the feat/clean-up-data branch August 21, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant