Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix username/password login #487

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Fix username/password login #487

merged 1 commit into from
Sep 25, 2022

Conversation

VMelnalksnis
Copy link
Owner

Fixes #486.

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #487 (ff6645c) into master (67308d6) will decrease coverage by 0.03%.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   66.33%   66.30%   -0.04%     
==========================================
  Files         279      278       -1     
  Lines        8389     8417      +28     
  Branches      551      557       +6     
==========================================
+ Hits         5565     5581      +16     
- Misses       2651     2659       +8     
- Partials      173      177       +4     
Impacted Files Coverage Δ
...omeshade.WebApi/Configuration/AuthConfiguration.cs 91.01% <53.33%> (-8.99%) ⬇️
...Gnomeshade.WebApi.Client/TokenDelegatingHandler.cs 72.97% <83.33%> (+7.97%) ⬆️
...ource/Gnomeshade.WebApi.Client/GnomeshadeClient.cs 78.57% <100.00%> (-0.34%) ⬇️
...urce/Gnomeshade.WebApi.Client/GnomeshadeOptions.cs 0.00% <0.00%> (-100.00%) ⬇️
source/Gnomeshade.WebApi.Client/SuccessfulLogin.cs

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis merged commit ff6645c into master Sep 25, 2022
@VMelnalksnis VMelnalksnis deleted the fix/authentication branch September 25, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username/password login does not work from desktop/API client
1 participant