Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction merging (#544) #546

Merged
merged 3 commits into from
Nov 5, 2022
Merged

Add transaction merging (#544) #546

merged 3 commits into from
Nov 5, 2022

Conversation

VMelnalksnis
Copy link
Owner

Fixes #544

Changes proposed in this pull request:

  • Add transaction merging
  • Remove redundant code from counterparty merging

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #546 (4088d8b) into master (5af4207) will decrease coverage by 0.02%.
The diff coverage is 66.03%.

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   67.96%   67.94%   -0.03%     
==========================================
  Files         302      303       +1     
  Lines        8991     9040      +49     
  Branches      655      658       +3     
==========================================
+ Hits         6111     6142      +31     
- Misses       2637     2655      +18     
  Partials      243      243              
Impacted Files Coverage Δ
...onia.Core/DesignTime/DesignTimeGnomeshadeClient.cs 72.75% <0.00%> (-0.24%) ⬇️
...nia.Core/Transactions/Controls/TransactionMerge.cs 25.00% <25.00%> (ø)
...Avalonia.Core/Transactions/TransactionViewModel.cs 63.11% <33.33%> (-3.25%) ⬇️
...eshade.Data/Repositories/CounterpartyRepository.cs 100.00% <100.00%> (+9.09%) ⬆️
source/Gnomeshade.Data/Repositories/Queries.cs 95.23% <100.00%> (+0.07%) ⬆️
...meshade.Data/Repositories/TransactionRepository.cs 100.00% <100.00%> (ø)
...ource/Gnomeshade.WebApi.Client/GnomeshadeClient.cs 79.85% <100.00%> (+0.30%) ⬆️
source/Gnomeshade.WebApi.Client/Routes.cs 95.23% <100.00%> (+0.11%) ⬆️
...de.WebApi/V1/Controllers/TransactionsController.cs 90.32% <100.00%> (+0.40%) ⬆️
...estingHelpers/Models/GnomeshadeClientExtensions.cs 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VMelnalksnis VMelnalksnis merged commit 4088d8b into master Nov 5, 2022
@VMelnalksnis VMelnalksnis deleted the merge-transactions branch November 5, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add transaction merging
1 participant